Ignore error frames in can.player by default#690
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #690 +/- ##
===========================================
+ Coverage 68.67% 68.71% +0.03%
===========================================
Files 69 69
Lines 6254 6249 -5
===========================================
- Hits 4295 4294 -1
+ Misses 1959 1955 -4 |
Codecov Report
@@ Coverage Diff @@
## develop #690 +/- ##
===========================================
+ Coverage 65.69% 68.71% +3.01%
===========================================
Files 69 69
Lines 6134 6249 +115
===========================================
+ Hits 4030 4294 +264
+ Misses 2104 1955 -149 |
Lauszus
approved these changes
Sep 4, 2019
Collaborator
Lauszus
left a comment
Lauszus
left a comment
There was a problem hiding this comment.
Looks good to me as well.
Merged
hardbyte
pushed a commit
that referenced
this pull request
Dec 28, 2019
Expose options to send or skip error frame messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are usually not of interest and may fill up the transmit buffer.
Fixes #683