Adding env marker to pywin32 requirements (extra)#1916
Merged
pierreluctg merged 1 commit intomainfrom Feb 3, 2025
Merged
Conversation
As part of #1833, the `pywin32` requirements environment markers got dropped when moving the requirement to an extra.
zariiii9003
approved these changes
Feb 2, 2025
Collaborator
zariiii9003
left a comment
zariiii9003
left a comment
There was a problem hiding this comment.
That was intentional. I thought: If the user explicitely requests pywin32, then installation should fail if it is not available.
But i can see use cases, where that might be annoying, so approved :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #1833, the
pywin32requirements environment markers got dropped when moving the requirement to an extra.