Improve speed of TRCReader#1893
Merged
zariiii9003 merged 1 commit intohardbyte:mainfrom Nov 26, 2024
TheTrueAI:patch-1
Merged
Conversation
zariiii9003
reviewed
Nov 15, 2024
zariiii9003
reviewed
Nov 23, 2024
can/io/trc.py
Outdated
| super().__init__(file, mode="r") | ||
| self.file_version = TRCFileVersion.UNKNOWN | ||
| self.start_time: Optional[datetime] = None | ||
| self.start_time: float = 0 |
Collaborator
There was a problem hiding this comment.
This attribute is public, so changing the type could break user code. I'd suggest creating a private float attribute _timestamp and a property timestamp, that returns a datetime instance like before.
Otherwise this looks good to me.
Contributor
Author
There was a problem hiding this comment.
Good point! Changed it
Merged
Rewrote some lines in the TRCReader to optimize for speed, mainly for TRC files v2.x. According to cProfile it's double as fast now.
zariiii9003
approved these changes
Nov 26, 2024
Collaborator
zariiii9003
left a comment
zariiii9003
left a comment
There was a problem hiding this comment.
Looks good, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimized TRCReader for speed, mainly for TRC files v2.x. According to cProfile it's double as fast now.