add silent mode support for vector#1764
Merged
zariiii9003 merged 3 commits intohardbyte:mainfrom Jun 7, 2024
Merged
Conversation
zariiii9003
reviewed
Apr 16, 2024
can/interfaces/vector/canlib.py
Outdated
| self.index_to_channel: Dict[int, int] = {} | ||
| self._can_protocol = CanProtocol.CAN_FD if is_fd else CanProtocol.CAN_20 | ||
|
|
||
| self.silent_mode = kwargs.get('silent_mode', False) |
Collaborator
There was a problem hiding this comment.
I'd prefer listen_only like in socketcan. Also, make this variable private.
Collaborator
|
Are you still working on the failing tests? |
works as expected
Contributor
Author
|
@zariiii9003 looks like tests are passing except one that is known to periodically fail |
zariiii9003
approved these changes
Apr 23, 2024
Collaborator
zariiii9003
left a comment
zariiii9003
left a comment
There was a problem hiding this comment.
Looks good, thank you
Contributor
Author
|
@zariiii9003 is this ready to get merged in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
haven't tested on hardware yet