Merged
Conversation
fix tests
Contributor
Author
|
hmm not really sure why tests are failing for python 3.11 (windows) only, maybe someone can trigger a re-run? |
zariiii9003
approved these changes
Mar 12, 2024
Collaborator
zariiii9003
left a comment
zariiii9003
left a comment
There was a problem hiding this comment.
Thanks for adding a test! Looks good.
This was referenced Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for .trc log files as generated by e.g. PCAN Explorer v5
After implementing the change I noticed that there is already two open PRs implementing the same (:
-> #1638 and #1727
However this might be easier to merge since build passes (when i run it locally) and a corresponding test has been added