Fix socketcand erroneously discarding frames#1700
Merged
zariiii9003 merged 1 commit intohardbyte:mainfrom Dec 5, 2023
Merged
Conversation
The __receive_buffer is always truncated by [chars_processed_successfully + 1:]. When a partial socketcand frame is received, chars_processed_successfully is 0, and this results in 1 character being discarded. This will be the '<' character, and thus when the rest of the frame is received, it will be treated as a bad frame, and discarded.
faisal-shah
force-pushed
the
fix/partial-frame-discarded-erroneously
branch
from
97883f5 to
9a8dbd6
Compare
zariiii9003
approved these changes
Dec 1, 2023
lumagi
approved these changes
Dec 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The __receive_buffer is always truncated by [chars_processed_successfully + 1:]. When a partial socketcand frame is received, chars_processed_successfully is 0, and this results in 1 character being discarded. This will be the '<' character, and thus when the rest of the frame is received, it will be treated as a bad frame, and discarded.
I double checked wireshark to make sure the bytestream wasn't corrupted, or there wasn't some weird latency related issue (which shouldn't make a difference anyways..). It was all good.
I also instrumented the code a bit to catch it in the act in the while loop progressively processing the
buffer_viewbuffer. Below is a log which shows it happening (scroll to the bottom):