add the possibility to return all the possible solutions using the from_sample_point static methods#1671
Merged
zariiii9003 merged 9 commits intohardbyte:developfrom Oct 12, 2023
Conversation
…om_sample_point static methods
Collaborator
|
Both me and mypy do not like the different return types of the What do you think about adding another method which generates BitTiming instances: The |
…danielhrisca/python-can into from_sample_point_all_solutions
… from_sample_point_all_solutions
Contributor
Author
|
@zariiii9003 thanks for the pointers, let me know if the new code is ok |
Collaborator
|
Looks good, could you add some trivial test? |
zariiii9003
approved these changes
Oct 12, 2023
Collaborator
zariiii9003
left a comment
There was a problem hiding this comment.
Looks good, thank you 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CAN databases can contain restrictions for the timings:
With this change the user can get all the possible solutions for a given sampling value and can further filter the solutions using the known constraints.