Add file_size() function to FileIOMessageWriter#1367
Merged
zariiii9003 merged 4 commits intohardbyte:developfrom Aug 10, 2022
Merged
Add file_size() function to FileIOMessageWriter#1367zariiii9003 merged 4 commits intohardbyte:developfrom
zariiii9003 merged 4 commits intohardbyte:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1367 +/- ##
========================================
Coverage 66.13% 66.13%
========================================
Files 86 86
Lines 8998 9004 +6
========================================
+ Hits 5951 5955 +4
- Misses 3047 3049 +2 |
Contributor
|
It appears that you plan to close #1359 with this PR. Do you plan to merge this and close #1360 without a merge? If so, there are changes in #1360 that are not included here, but should be to properly close #1359. I have created a pull request into your branch: zariiii9003#5. These additions will currently accomplish the following two items:
One additional item that I have not yet had time to address is based on @hardbyte's comment: |
File size
Collaborator
Author
|
I merged your changes. Once #1366 is merged, you can pass any parameters from the CLI to the logger instantiation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1359