Open
Conversation
This base class was misnamed. It's intended for all llvm-based backends that use a CPU-like memory architecture. I.e. there's a stack and a heap and halide_malloc and halide_free exist. This covers our existing CPU architectures, but also Hexagon and WebAssembly, which use CPU-like memory models. If we add more things that are shared across CPU-like architectures in future, they would go here. Runtime modules with "posix" in the name weren't renamed because that's more correct. Those are modules that implement our runtime by calling posix functions. No functional changes intended.
alexreinking
approved these changes
Apr 15, 2026
zvookin
reviewed
Apr 15, 2026
|
|
||
| /** \file | ||
| * Defines a base-class for code-generators on posixy cpu platforms | ||
| */ |
Member
There was a problem hiding this comment.
Might be good to expand this comment with some design thoughts of what this class encapsulates, such as memory allocation. (And perhaps some things it is not supposed to handle.)
…into abadams/codegen_cpu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This base class was misnamed. It's intended for all llvm-based backends that use a CPU-like memory architecture. I.e. there's a stack and a heap and halide_malloc and halide_free exist. This covers our existing CPU architectures, but also Hexagon and WebAssembly, which use CPU-like memory models. If we add more things that are shared across CPU-like architectures in future, they would go here. Runtime modules with "posix" in the name weren't renamed because that's more correct. Those are modules that implement our runtime by calling posix functions.
No functional changes intended.