Expose Runtime::Buffer::cropped to C++ and Python Buffer#8787
Merged
Conversation
Member
|
@abadams - do you know any reason this wasn't already exposed on the |
Member
|
I can't think of one that applies to cropped but doesn't apply to other methods like sliced or embedded. It looks like they were just added piecemeal. |
Author
|
I just noticed that |
alexreinking
requested changes
Aug 27, 2025
Member
alexreinking
left a comment
alexreinking
left a comment
There was a problem hiding this comment.
Can you add a test case for translated too?
rtzam
force-pushed
the
rtzam/add-cropped-to-buffer
branch
from
002b65b to
633972a
Compare
Author
|
@alexreinking, just added the test (and rebased from |
alexreinking
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #8785