Adding worker_thread_idle() for more informative profiling#8719
Conversation
|
@abadams Do we need to wrap other special conditions? |
mcourteaux
left a comment
There was a problem hiding this comment.
The calling overhead seems fine, as it's in idle circumstances.
|
Are we good on merging this? |
|
In fact, most types of spinning in the runtime are loops around yield calls, and yield dominates and will show up in the profiler, so I don't think we need to worry about encapsulating spins under a symbol Are we good to merge this? |
alexreinking
left a comment
There was a problem hiding this comment.
Looks good to me. I say merge.
Just a small cosmetic change to assist during profiling (make it clear when the worker threads are idling).