Add support for adding tuple outputs in the configure() method#8649
Merged
Add support for adding tuple outputs in the configure() method#8649
Conversation
alexreinking
approved these changes
Jun 12, 2025
Contributor
|
Thanks for the patch. I want to point out that the new Lines 1433 to 1435 in 16fde03 I'm not familiar enough with the compilation pipeline to say if it'll lead to undefined behaviour. It might be better to declare the new set_type signature as protected and only expose it as public in the output class.
|
Member
Author
|
Good call, I'll move it to the generator output subclass. |
steven-johnson
approved these changes
Jun 13, 2025
Member
|
Looks like a fuzz test failure? |
Member
Author
|
Fuzz failure fixed by #8674 |
Member
Author
|
Failures unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We also weren't asserting that the names used in add_output weren't already taken, which resulted in some confusing internal errors when I made that mistake.
Fixes #8643