Fix horrible Shuffle bug in GPU_C_Codegen and add test.#8553
Closed
mcourteaux wants to merge 5 commits intohalide:mainfrom
Closed
Fix horrible Shuffle bug in GPU_C_Codegen and add test.#8553mcourteaux wants to merge 5 commits intohalide:mainfrom
mcourteaux wants to merge 5 commits intohalide:mainfrom
Conversation
rootjalex
reviewed
Jan 29, 2025
rootjalex
reviewed
Jan 29, 2025
Contributor
Author
|
Closed in favor of #8567. Exactly same PR, but not from my forks main branch anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shuffle emitting in OpenCL was broken when the input to the
Shufflenode were actual vectors instead of scalar. For some reason, in most of the scenarios the codegen makes it's way to the Shuffle nodes, the Shuffles are containing all vectors with 1 lane, causing no real issue without this PR. Today I ran into codegen having to shuffle multiple actual vectors in the OpenCL codegen.@derek-gerstmann I had to disable Vulkan testing, because there is an issue on my machine with that. Could you check that out? Last excerpt from DEBUG_CODEGEN=1 output: