Skip to content

Fix CPack package naming when cross-compiling#8492

Merged
steven-johnson merged 2 commits intomainfrom
fix-cpack
Dec 2, 2024
Merged

Fix CPack package naming when cross-compiling#8492
steven-johnson merged 2 commits intomainfrom
fix-cpack

Conversation

@alexreinking
Copy link
Copy Markdown
Member

I expect this to work, but I need to get into the armbots to test it.

@alexreinking
Copy link
Copy Markdown
Member Author

Looks like ccache on one of the bots got messed up and there's a new LLVM 20 failure. This code doesn't run on the normal buildbots, so must be unrelated.

Copy link
Copy Markdown
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green

EDIT: this won't actually test the nightlies which are affected, and there isn't a way to easily test the nightlies outside of the main branch, so we'll land this once we get a handful of greens as a realtiy check

@steven-johnson steven-johnson merged commit e5e2510 into main Dec 2, 2024
@steven-johnson steven-johnson deleted the fix-cpack branch December 2, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants