Merged
Conversation
alexreinking
requested review from
abadams,
derek-gerstmann and
steven-johnson
Member
Author
|
Also, would that LLVM fixed their CMake targets! The include directory issue wouldn't have happened if they set up their targets correctly. Also, |
steven-johnson
approved these changes
Sep 30, 2024
Contributor
|
linuxbot4 is still semi-broken :-/ |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading to Homebrew's LLVM 19.1, I encountered some build failures that necessitate the following changes to our build.
brew install lld.lldWasmis built as a shared library now, and it no longer includeslldCommon, so I added that dependency.Technically, this could have happened with earlier versions of LLVM, only nobody had packaged it this way, until now.