Merged
Conversation
steven-johnson
requested changes
Sep 5, 2024
Contributor
steven-johnson
left a comment
There was a problem hiding this comment.
Looks great, just a few things that need tweaking
Member
Author
Well spotted issues, thanks! |
abadams
reviewed
Sep 5, 2024
abadams
reviewed
Sep 5, 2024
abadams
reviewed
Sep 5, 2024
abadams
reviewed
Sep 5, 2024
abadams
reviewed
Sep 5, 2024
abadams
reviewed
Sep 5, 2024
abadams
reviewed
Sep 5, 2024
steven-johnson
approved these changes
Sep 5, 2024
mcourteaux
pushed a commit
to mcourteaux/Halide
that referenced
this pull request
Sep 15, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a big documentation update. I have:
README_*.mdfiles todoc/and added links to them to the baseREADME.mddoc/Hexagon.md.README_cmake.mdinto three more specialized documents (and updated the documentation,CMAKE_OSX_ARCHITECTURESsupport, c.f. Support CMAKE_OSX_ARCHITECTURES #8390README_python.md~>doc/Python.md.The best way to review this PR will be to actually read the documentation, which is navigable starting from here:
Additional files with substantial changes are here: