Fix Numpy 2.0 compatibility bug in lesson 10#8381
Merged
alexreinking merged 1 commit intomainfrom Aug 9, 2024
Merged
Conversation
Numpy 2.0 no longer performs narrowing conversions automatically. We manually mask here instead. Fixes #8380
Merged
steven-johnson
approved these changes
Aug 9, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Numpy 2.0 compatibility bug in lesson 10
Numpy 2.0 no longer performs narrowing conversions
automatically. We manually mask here instead.
Fixes #8380