Remove OpenGLCompute

[steven-johnson]

This was supposed to be removed in Halide 17 (oops), removing for Halide 18

[shoaibkamil]

LGTM, thanks for doing this!

@TH3CHARLie Do we need to bump the serialization version? I'm not sure what our approach has been when deprecating features (maybe this is the first time since serialization was added).

[steven-johnson]

LGTM, thanks for doing this!

@TH3CHARLie Do we need to bump the serialization version? I'm not sure what our approach has been when deprecating features (maybe this is the first time since serialization was added).

IMHO we should probably bump the version for every Halide release, regardless

[TH3CHARLie]

LGTM, thanks for doing this!

@TH3CHARLie Do we need to bump the serialization version? I'm not sure what our approach has been when deprecating features (maybe this is the first time since serialization was added).

I think anything that changes the serialization definition needs to bump the serialization version, on the minor number(i.e. 0.1.0 -> 0.1.1). And second to Steven's comment, we should bump the serialization version number on every major release.

[steven-johnson]

LGTM, thanks for doing this!
@TH3CHARLie Do we need to bump the serialization version? I'm not sure what our approach has been when deprecating features (maybe this is the first time since serialization was added).

I think anything that changes the serialization definition needs to bump the serialization version, on the minor number(i.e. 0.1.0 -> 0.1.1). And second to Steven's comment, we should bump the serialization version number on every major release.

#8080

[TH3CHARLie]

One thing I found about this PR is that, the serialization version numbers help users to find out they are deserializing from an old binary pipeline. But on the other hand, if you are using an old Halide build with a updated binary pipeline, the code may crash before we start to check the version numbers (because of a format change in this PR in particular):

Halide/src/Deserialization.cpp

Line 1405 in 9a740b5

const auto *pipeline_obj = Serialize::GetPipeline(data.data());

(GetPipeline would crash internally here I believe)