StmtViz: Search for tooltip only in the child node#7754
Merged
steven-johnson merged 1 commit intohalide:mainfrom Aug 10, 2023
Merged
StmtViz: Search for tooltip only in the child node#7754steven-johnson merged 1 commit intohalide:mainfrom
steven-johnson merged 1 commit intohalide:mainfrom
Conversation
Further cut ~5 second of StmtVisualizer rendering by searching for the tooltip text-box in the child node of the current button. Previously, the script compose the global ID with regular expression, and then search the entire DOM causing delays.
antonysigma
changed the title
maaz139
approved these changes
Aug 10, 2023
Contributor
maaz139
left a comment
maaz139
left a comment
There was a problem hiding this comment.
Good catch! Change looks good to me.
steven-johnson
approved these changes
Aug 10, 2023
Contributor
|
Oooh, let's try this! Will report back soon. |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
Search for tooltip only in the child node Further cut ~5 second of StmtVisualizer rendering by searching for the tooltip text-box in the child node of the current button. Previously, the script compose the global ID with regular expression, and then search the entire DOM causing delays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further cut ~5 second of StmtVisualizer rendering by searching for the tooltip text-box in the child node of the current button. Previously, the script compose the global ID with regular expression, and then search the entire DOM causing delays.
Quoting the comments from #7713:
Resolves: #7712 .
See also: #7713 .
cc'ed @maaz139 and @mcourteaux .