[vulkan] Fix SPIR-V IR references causing leaks#7739
Merged
steven-johnson merged 2 commits intomainfrom Aug 7, 2023
Merged
Conversation
added 2 commits
August 3, 2023 12:53
Add explicit clear methods for contents structs and destructors.
steven-johnson
approved these changes
Aug 3, 2023
Contributor
steven-johnson
left a comment
steven-johnson
left a comment
There was a problem hiding this comment.
Thanks so much for this! LGTM pending green.
Contributor
Author
Thanks for finding these! The ASAN toolchain is a massive help! |
Member
|
I believe after this PR and the memoize fix one (which is still failing on windows, unfortunately), that's all the leaks. |
Contributor
Sweet! LMK how the Windows issues go. |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Remove unnecessary parent refs and owning function/block refs. Add explicit clear methods for contents structs and destructors. * Move objects when changing ownership --------- Co-authored-by: Derek Gerstmann <dgerstmann@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed parent/owner back references (which weren't actually needed)
Fixed ownership transfers
Explicitly destruct and clear contents