Forbid assigning to Buffer(Expr) by introducing an intermediate type.#7517
Merged
Forbid assigning to Buffer(Expr) by introducing an intermediate type.#7517
Conversation
steven-johnson
approved these changes
Apr 17, 2023
Contributor
steven-johnson
left a comment
steven-johnson
left a comment
There was a problem hiding this comment.
LGTM -- should we add an error-test to verify it stays broken?
Member
Author
|
The issue is that it's a C++ compile-time failure, not a Halide compile-time failure, so I don't think an error test is possible. |
Contributor
|
Ready to land? |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
…halide#7517) * Forbid assigning to Buffer(Expr) by introducing an intermediate type. Fixes halide#7514 * Simpler solution * Silence clang-tidy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7514 by triggering a compile-time error instead of silently doing something surprising.