docs: Use halide.imageio instead of imageio#7409
Merged
steven-johnson merged 2 commits intohalide:mainfrom Mar 11, 2023
Ttayu:docs/Use_halide_imageio
Merged
docs: Use halide.imageio instead of imageio#7409steven-johnson merged 2 commits intohalide:mainfrom Ttayu:docs/Use_halide_imageio
steven-johnson merged 2 commits intohalide:mainfrom
Ttayu:docs/Use_halide_imageio
Conversation
steven-johnson
approved these changes
Mar 11, 2023
Contributor
steven-johnson
left a comment
steven-johnson
left a comment
There was a problem hiding this comment.
Thanks for the fix!
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* docs: Use halide.imageio instead of imageio * trigger buildbots --------- Co-authored-by: Steven Johnson <srj@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the missing fix in the #7402 pull request. (i'm sorry)
Additionally, I have added assert statements. This is because the image created in the first example is of shape
[512, 512, 3], while the example being used to compute xor_filter is of shape[512, 512]. To avoid confusion for the user, I made it explicit.