Bounds visitors for min/max were missing single_point mutated case#7377
Merged
Bounds visitors for min/max were missing single_point mutated case#7377
Conversation
steven-johnson
approved these changes
Feb 24, 2023
Contributor
steven-johnson
left a comment
steven-johnson
left a comment
There was a problem hiding this comment.
Do we need a test for this?
Member
Author
|
I'm not sure how I'd repro in a small test - it only showed up as suboptimal-but-still-correct lowering in a complex pipeline. Given that this just makes these visitors match their neighbors, I'm inclined to not add a specific test for this. |
Member
Author
|
Actually I just figured it out, so small test incoming... |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
…alide#7377) * Bounds visitors for min/max were missing single_point mutated case Partially fixes halide#7374 * Add test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other visitors handle this case, but it was inexplicably missing from min/max. This causes later checks to is_single_point to suboptimally return false because we get two distinct but equal Exprs.
Partially fixes #7374