Update WABT to 1.0.32; Increase stack size for WASM AOT apps#7373
Merged
steven-johnson merged 1 commit intomainfrom Feb 23, 2023
Merged
Update WABT to 1.0.32; Increase stack size for WASM AOT apps#7373steven-johnson merged 1 commit intomainfrom
steven-johnson merged 1 commit intomainfrom
Conversation
alexreinking
approved these changes
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WABT upgrading is just to stay up to date.
The stack size increase is because the most recent versions of Emscripten have slightly greater stack usage in some cases, and we were close enough to the default (64k) for at least one test that the increase put us over the limit. Increased to 96k.