Skip to content

Fix segfault by nonconstant bound in Adams2019 #7321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steven-johnson merged 1 commit into from
Feb 6, 2023
Merged

Fix segfault by nonconstant bound in Adams2019 #7321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/autoschedulers/adams2019/FunctionDAG.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,8 +874,11 @@ FunctionDAG::FunctionDAG(const vector<Function> &outputs, const Target &target)
// Get the bounds estimate
map<string, Span> estimates;
for (const auto &b : consumer.schedule().estimates()) {
int64_t i_min = *as_const_int(b.min);
int64_t i_extent = *as_const_int(b.extent);
const int64_t *i_min = as_const_int(b.min);
const int64_t *i_extent = as_const_int(b.extent);
user_assert(i_min && i_extent)
<< "Min/extent of estimate or bound is not constant in \"" << consumer.name()
<< "\", var:" << b.var << ", min:" << b.min << ", extent:" << b.extent;

if ((false)) { // Intentional dead code. Extra parens to pacify clang-tidy.
// Some methods we compare to compile for
Expand All @@ -891,9 +894,9 @@ FunctionDAG::FunctionDAG(const vector<Function> &outputs, const Target &target)
// like unroll across color channels, so
// it affects the scheduling space.
Func(node.func).bound(b.var, b.min, b.extent);
estimates[b.var] = Span(i_min, i_min + i_extent - 1, true);
estimates[b.var] = Span(*i_min, *i_min + *i_extent - 1, true);
} else {
estimates[b.var] = Span(i_min, i_min + i_extent - 1, false);
estimates[b.var] = Span(*i_min, *i_min + *i_extent - 1, false);
}
}
for (const auto &b : consumer.schedule().bounds()) {
Expand Down