Make Callable::call_argv_fast public#7315
Merged
steven-johnson merged 3 commits intohalide:mainfrom Feb 1, 2023
Merged
Conversation
Contributor
Probably not, at least not as well as it should be. Basically:
|
steven-johnson
approved these changes
Jan 31, 2023
Contributor
steven-johnson
left a comment
steven-johnson
left a comment
There was a problem hiding this comment.
LGTM pending green buildbots.
Contributor
Author
|
One of the Windows builds is failing. It can't have anything to do with the latest commits, can it? I've only changed the wording in the comments... |
Contributor
Yes, unfortunately our Windows buildbots are in need of some love and that's one of the flakes. This is fine to land. |
steven-johnson
pushed a commit
that referenced
this pull request
Feb 28, 2023
* Make Callable::call_argv_fast public * Add rough specification of the calling convention * Fix a typo
steven-johnson
added a commit
that referenced
this pull request
Mar 1, 2023
* Make Callable::call_argv_fast public (#7315) * Make Callable::call_argv_fast public * Add rough specification of the calling convention * Fix a typo * Add Callable default ctor + `defined()` method (#7380) * Add Callable default ctor + `defined()` method This allows it to behave like * Add user_assert + test --------- Co-authored-by: Tom Westerhout <14264576+twesterhout@users.noreply.github.com>
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Make Callable::call_argv_fast public * Add rough specification of the calling convention * Fix a typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #7314.
I'm wondering, is the argv-based calling convention is documented somewhere? If so, I can add a reference to the doc string.