Skip to content

Warn emulated float16 equivalent is generated#7307

Merged
steven-johnson merged 10 commits intohalide:mainfrom
stevesuzuki-arm:warn_fp16emu
Feb 7, 2023
Merged

Warn emulated float16 equivalent is generated#7307
steven-johnson merged 10 commits intohalide:mainfrom
stevesuzuki-arm:warn_fp16emu

Conversation

@stevesuzuki-arm
Copy link
Copy Markdown
Contributor

@stevesuzuki-arm stevesuzuki-arm commented Jan 27, 2023

Improvement for the issue #7306

steven-johnson
steven-johnson reviewed Jan 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the mechanism for making it "one-time" (via LINE) seems kinda wonky.

Comment thread src/CodeGen_LLVM.cpp Outdated
@steven-johnson
Copy link
Copy Markdown
Contributor

steven-johnson commented Jan 31, 2023

(I think this is good to land but waiting on a hopefully-all-green result now that some LLVM fixes have landed from upstream)

@steven-johnson
halide_popcount<uint64_t> is broken
5dc9df4 
Would not compile for Win32 or any other compiler without __builtin_popcountll available. (How did this get checked in without being tested on MSVC?)
@steven-johnson
Merge branch 'srj/popcnt' into pr/7307
7281390
@steven-johnson
Copy link
Copy Markdown
Contributor

steven-johnson commented Jan 31, 2023

(I merged #7313 in here so that we could get a not-complete-broken Windows build :-/)

abadams
abadams reviewed Jan 31, 2023
View reviewed changes
Comment thread src/CodeGen_LLVM.cpp
@steven-johnson
Copy link
Copy Markdown
Contributor

steven-johnson commented Jan 31, 2023

This is weird: the new 'warning' is being emitted and yet the test is failing? https://buildbot.halide-lang.org/master/#/builders/11/builds/7/steps/13/logs/warning_emulated_float16

@steven-johnson
Copy link
Copy Markdown
Contributor

steven-johnson commented Jan 31, 2023

This is weird: the new 'warning' is being emitted and yet the test is failing? https://buildbot.halide-lang.org/master/#/builders/11/builds/7/steps/13/logs/warning_emulated_float16

Ah, the failure is because we are writing to /dev/null... which is Not A Thing on Windows. I'll push a fix.

@steven-johnson steven-johnson merged commit 0b7379f into halide:main Feb 7, 2023
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
@stevesuzuki-arm @ardier
Warn emulated float16 equivalent is generated (halide#7307)
9325c6b 
* Warn emulated float16 equivalent is generated
@stevesuzuki-arm stevesuzuki-arm deleted the warn_fp16emu branch December 1, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

@abadams abadams abadams left review comments

@halidebuildbots halidebuildbots Awaiting requested review from halidebuildbots

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stevesuzuki-arm @steven-johnson @abadams