Inline into extern function args during bounds inference#7261
Merged
Conversation
steven-johnson
requested changes
Dec 30, 2022
Contributor
steven-johnson
left a comment
steven-johnson
left a comment
There was a problem hiding this comment.
Looks good so far, but every bot is failing...
| return false; | ||
| } | ||
|
|
||
| class Inliner : public IRMutator { |
Contributor
There was a problem hiding this comment.
nit: worth inserting a comment here about why this is necessary in addition to the previously existing inliner elsewhere
Member
Author
|
Failing the test python_correctness_realize_warnings because it only prints the warning twice instead of three times. I'm confused about why it would print it more than once. Any ideas? |
as long as it's at least once
…nto abadams/fix_7260
Member
Author
|
I just changed the test to assert that the warning is printed at least once, and that nothing else is printed. |
Contributor
|
I guess the more interesting question here is how/why this PR caused any difference in that at all, whether or not the test made good sense in the first place... |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Inline into extern function args during bounds inference Fixes halide#7260 * Run CSE once at the end * Actually recursively inline * clang-tidy * trigger buildbots * Make test invariant to the number of times the warning is printed as long as it's at least once Co-authored-by: Steven Johnson <srj@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7260