[WASM] Use rounding_mul_shift_right for q15mulr_sat_s pattern#7134
Merged
[WASM] Use rounding_mul_shift_right for q15mulr_sat_s pattern#7134
Conversation
Contributor
|
Do we need an updated test in simd_op_check? |
Member
Author
|
No, this change should have not introduce any code generation change - it just makes code generation (slightly) faster.
|
steven-johnson
approved these changes
Oct 28, 2022
Member
Author
|
Test failure appears unrelated |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
…#7134) Use rounding_mul_shift_right for WASM q15mulr_sat_s pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that the
q15mulr_sat_srule didn't use the corresponding intrinsic - meaning we'd lowerrounding_mul_shift_rightjust to match the rule before.