[x86] Generate AVX512 fixed-point instructions#7129
Merged
Conversation
Contributor
|
Several legit failures here |
Member
Author
|
Can't quite figure out why the JIT doesn't like |
Member
Author
|
Ugh, same deal with the |
Member
Author
|
Just updated the AVX512_Skylake |
Member
Author
|
Only test failure appears unrelated |
abadams
reviewed
Oct 28, 2022
steven-johnson
approved these changes
Oct 31, 2022
Contributor
steven-johnson
left a comment
steven-johnson
left a comment
There was a problem hiding this comment.
LGTM, tests pass on my AVX512 Linux box
abadams
approved these changes
Oct 31, 2022
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* clean-up abs and saturating_pmulhrs, fix AVX512 saturating_ ops * add test coverage for AVX512 fp ops * generate vpabs on AVX512 * faster AVX2 lowering of saturating_pmulhrs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for generating
saturating_(add | sub)andpmulh(rs)on Skylake and Cannonlake (i.e. for AVX512BW). It also increases simd_op_check test coverage of fixed-point operations on those archs.I also did a bit of clean-up on the way:
absI did not addabsto codegen because it doesn't appear that LLVM currently exposes non-masked versions of AVX512absvariants.Fixes #7002