Merged
Conversation
widening_mul handles mixed-signedness args, but mul_shift_right doesn't. We shouldn't map a mixed-signedness widening_mul to a mul_shift_right.
abadams
added
bug
backport me
steven-johnson
approved these changes
Feb 8, 2022
shoaibkamil
reviewed
Feb 8, 2022
| auto is_x_same_int = op->type.is_int() && is_int(x, bits); | ||
| auto is_x_same_uint = op->type.is_uint() && is_uint(x, bits); | ||
| auto is_x_same_int_or_uint = is_x_same_int || is_x_same_uint; | ||
| auto x_y_same_sign = (is_int(x) && is_int(y)) || (is_uint(x) && is_uint(y)); |
Contributor
There was a problem hiding this comment.
I think a comment here would help-- it's not necessarily clear at first glance what is_int() means compared to Type::is_int()
shoaibkamil
approved these changes
Feb 8, 2022
Member
Author
|
Failure unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
widening_mul handles mixed-signedness args, but mul_shift_right doesn't.
We shouldn't map a mixed-signedness widening_mul to a mul_shift_right.