Fixes the Pytorch Wrapper Codegen for CPU-only machines.#6590
Merged
steven-johnson merged 4 commits intohalide:masterfrom Jan 27, 2022
Merged
Fixes the Pytorch Wrapper Codegen for CPU-only machines.#6590steven-johnson merged 4 commits intohalide:masterfrom
steven-johnson merged 4 commits intohalide:masterfrom
Conversation
added 2 commits
January 26, 2022 16:42
… context for auto-scheduled-ops
steven-johnson
approved these changes
Jan 27, 2022
Contributor
steven-johnson
left a comment
steven-johnson
left a comment
There was a problem hiding this comment.
LGTM pending green, with nits
Contributor
|
Please also use the |
jrprice
pushed a commit
to jrprice/Halide
that referenced
this pull request
Feb 4, 2022
* fixes pytorch op compilation for CPU only machines, adds default user context for auto-scheduled-ops * rm redundant declarations * fix spacing Co-authored-by: Michael Gharbi <mgharbi@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
halide_cuda_device_interfaceis missing.__user_context = nullptrin CPU-only ops. The auto-scheduler can create intermediate functions that have a __user_context input. This case was not handled by the CodeGen, so compilation would fail. We now create a default null context instead.