Drop support for LLVM11

[steven-johnson]

With Halide 13 released, we should drop support for LLVM11 in Halide trunk, since we only promise to support LLVM trunk + two releases.

[steven-johnson]

attn @alinas

[steven-johnson]

@alexreinking -- not sure about the packaging-for-Ubuntu workflow, I just updated to use LLVM12 instead, but not sure if that's kosher

[abadams]

This looks like you deleted an llvm 12 block

[steven-johnson]

No, I think it's just that the >=120 block was very similar to the else block here (just an extra arg to the lambda passed to registerPipelineStartEPCallback)

[abadams]

lgtm except for two bits that confused me

[abadams]

This also looks like an llvm 12 block

[steven-johnson]

it is, but we are keeping it

[abadams]

But it's an == 120 block, not a >= 120 block, so by keeping it aren't we testing the wrong thing on llvm 13?

Or is the original check wrong?

[abadams]

bump. I'm confused about why this isn't going to cause simd op check failures on llvm 13+

Or were we only testing wasm on llvm 12 before?

[abadams]

Old code:

                    if (Halide::Internal::get_llvm_version() == 120) {
                        check("i64x2.splat", 8 * w, u16_1 * u16(42));
                        check("i64x2.splat", 4 * w, u32_1 * u32(42));
                    } else {
                        check("i16x8.splat", 8 * w, u16_1 * u16(42));
                        check("i32x4.splat", 4 * w, u32_1 * u32(42));
                   }

New code:

                    check("i64x2.splat", 8 * w, u16_1 * u16(42));
                    check("i64x2.splat", 4 * w, u32_1 * u32(42));

I think the new code is just the llvm_version() == 120 version, so aren't we changing the expected output for llvm 13/14?

I can't figure out what I'm missing.

[alexreinking]

@steven-johnson - you need to update 11 to 12 here:

Halide/packaging/ubuntu/config.cmake

Lines 63 to 67 in 6071cf6

	# Package dependencies.
	# TODO: figure out how to get LLVM major version piped in here.
	set(CPACK_DEBIAN_HALIDE_RUNTIME_PACKAGE_DEPENDS "llvm-11 (>= 11.0.0)")
	set(CPACK_DEBIAN_HALIDE_DEVELOPMENT_PACKAGE_DEPENDS "llvm-11-dev (>= 11.0.0), liblld-11-dev (>= 11.0.0)")
	set(CPACK_DEBIAN_HALIDE_DOCUMENTATION_PACKAGE_DEPENDS "")

[steven-johnson]

I'm confused about why this isn't going to cause simd op check failures on llvm 13+

We were only testing on llvm14 before, actually, but I still think you are misreading the diff.

I'll test this locally on 12/13/14 to verify, though.

[steven-johnson]

I'll test this locally on 12/13/14 to verify, though.

Passes for all three, so I think we are good.

[steven-johnson]

I can't figure out what I'm missing.

You're missing the fact that the >= 130 case is handled above -- the section you're looking at is in the else case.

[abadams]

Ah! Everything is now clear.