Create helper script to run IWYU on Halide#6251
Draft
steven-johnson wants to merge 10 commits intomainfrom
Draft
Create helper script to run IWYU on Halide#6251steven-johnson wants to merge 10 commits intomainfrom
steven-johnson wants to merge 10 commits intomainfrom
Conversation
Closed
steven-johnson
added
the
skip_buildbots
Contributor
Author
|
I'm going to convert this to draft (but leave it open), since it seems unlikely to be of interest any time soon. (I'll harvest a couple of minor changes to land separately). |
steven-johnson
added a commit
that referenced
this pull request
Oct 21, 2021
A couple of minor hygiene changes, extracted from #6251: - Clean up LLVM_Headers.h to uniformly use <> instead of "" and to alphabetize properly - Clean up WABT includes to reflect what we need more accurately
steven-johnson
added a commit
that referenced
this pull request
Oct 26, 2021
A couple of minor hygiene changes, extracted from #6251: - Clean up LLVM_Headers.h to uniformly use <> instead of "" and to alphabetize properly - Clean up WABT includes to reflect what we need more accurately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My main workstation was offline friday afternoon thru monday morning, so I took the opportunity to try to plug in IWYU, which is infamously ticklish to get right. This PR includes a helper script to run it, along with a 'mapping' file and a handful of changes to source code to enable IWYU to avoid getting confused and making a mess. (There will be a dependent PR off of this one that will actually apply IWYU.)
In theory, this sort of cleanup could improve compile speed; however, I'm not noticing anything meaningful in my local timings (though perhaps the armbots may notice a change). The appeal is more one of appealing to OCD, frankly.
Please note that unlike clang-format or clang-tidy, this is NOT intended to be run on a regular basis (and certainly not as a presubmit check); because of the nature of C++ includes, getting IWYU is a bit of a black art and fairly system dependent. I only bothered to get this running correctly on OSX using a Homebrew-installed IWYU 0.16; running on anything else is likely to require manual tweaking and examination every time this is used, which should be infrequent.