Migrate Hackster to Pydantic v2#184
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
==========================================
+ Coverage 65.15% 65.18% +0.02%
==========================================
Files 52 52
Lines 3042 3056 +14
==========================================
+ Hits 1982 1992 +10
- Misses 1060 1064 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d499273 to
fd63086
Compare
0xRy4n
approved these changes
Jun 2, 2026
Member
0xRy4n
left a comment
There was a problem hiding this comment.
Sorry this took so long to look at.
Changes look fine to me, only thing worth noting is that .docker.env did not get it's variables updated to match the changes to .test.env -- It still uses the MYSQL_ prefix instead of the DATABASE__ prefix.
I've added that small change and also resolved the conflicts with main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply.Proposed changes
pydantic-settingsBOT,DATABASE,CHANNEL, andROLEsrc/core/constants.pyThis PR also keeps the settings surface compatible with the current code shape by preserving
settings.bot,settings.database,settings.channels,settings.roles, andsettings.role_groups.Operational note: this changes the new config contract to nested env keys such as
BOT__TOKEN,DATABASE__HOST,CHANNEL__SR_MOD, andROLE__VERIFIED. During rollout, the old flat env keys can coexist in Vault alongside the new nested ones so the current production bot and this branch can run safely in parallel.Checklist
Put an
xin the boxes that apply.doc.
Additional context
Full test suite result on this branch:
PYTHONPATH=. uv run pytest276 passed, 12 warningsThe warnings are pre-existing test/runtime warnings and were not introduced by this migration.