'Support both csso v1 and v2' - Improved code in handling csso optimization function (justDoIt vs. minify)#226
Merged
alundiak merged 1 commit intoguybedford:masterfrom Feb 19, 2017
alundiak:219-pr-suggestion
Merged
'Support both csso v1 and v2' - Improved code in handling csso optimization function (justDoIt vs. minify)#226alundiak merged 1 commit intoguybedford:masterfrom alundiak:219-pr-suggestion
alundiak merged 1 commit intoguybedford:masterfrom
alundiak:219-pr-suggestion
Conversation
…zation function (justDoIt vs. minify)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cssoreleases review:Tested with:
0.1.8as a base.1.3.12,1.4.0,1.8.0,2.0.0and latest (checked 2017/02/18)2.3.1.2.1.10and2.3.26.9.5+ npm3.10.107.5.2+ npm4.1.2r.js -o example/build.jswith all possible values foroptimizeCssCompatibility Note: I realize, this change may be overthinking/overcomplex, but so far the fact is - there are end consumers of
require-csswho will upgrade to newrequire-cssversion, but remain oldcssoversion--globalor as in my enterprise case (locally in project).They will have errors like I mentioned in this PR and in #203 and #219.
A bit of automation :) in this boring life
compatibility-test.sh.optimizeCssinexample/build.jsfile from"none"tooptimizeCss: "standard.keepLines"optimizeCss: "standard.keepWhitespace"optimizeCss: "standard.keepComments"optimizeCss: "standard.keepComments.keepLines"optimizeCss: "standard.keepLines.keepWhitespace"- default byr.jscompatibility.log. By searching valueCompressed CSS outputin that log file, u should see always all good, no Syntax Errors. Active for Feb-19-2017.cc/ @guybedford @prantlf