Skip to content

Source k8s test driver install script from core repo#8573

Merged
temawi merged 12 commits intogrpc:masterfrom
temawi:shared-test-driver-install
Oct 7, 2021
Merged

Source k8s test driver install script from core repo#8573
temawi merged 12 commits intogrpc:masterfrom
temawi:shared-test-driver-install

Conversation

@temawi
Copy link
Copy Markdown
Contributor

@temawi temawi commented Sep 29, 2021

The shell script for installing the test driver for k8s interop tests will be maintained in a single place in the core C/C++ repo and sourced from the master branch by other gRPC repos.

The test driver install script is downloaded directly from GitHub with curl.

Successful test runs:

xds-k8s: https://fusion2.corp.google.com/invocations/45e95541-c5ff-4d6d-aee6-e30662bccc84/targets
xds_url_map: https://fusion2.corp.google.com/invocations/f7b5ad17-e37b-4716-bebb-5bea0a6cb926/targets

The core repo is cloned to acquire the test driver provisioning script instead of reading a copy of it from the Java repo.
The core repo is cloned to acquire the test driver provisioning script instead of reading a copy of it from the Java repo.
… shared-test-driver-install

# Conflicts:
#	buildscripts/kokoro/xds-k8s.sh
… shared-test-driver-install

# Conflicts:
#	buildscripts/kokoro/xds-k8s.sh
@temawi temawi requested a review from sergiitk September 29, 2021 21:15
Comment thread buildscripts/kokoro/xds-k8s.sh Outdated
Co-authored-by: Sergii Tkachenko <hi@sergii.org>
@sanjaypujare
Copy link
Copy Markdown
Contributor

Is this PR affected by the freeze that was announced?

@temawi
Copy link
Copy Markdown
Contributor Author

temawi commented Sep 29, 2021

Is this PR affected by the freeze that was announced?

Yes, I won't merge this until the security release has completed. Same deal for my PRs in core and Go repos.

@temawi temawi merged commit 83d3610 into grpc:master Oct 7, 2021
@temawi temawi deleted the shared-test-driver-install branch October 13, 2021 20:55
temawi added a commit to temawi/grpc-java that referenced this pull request Oct 13, 2021
The test driver install script is read directly from the core repo master branch and the copy in the Java repo is deleted.
temawi added a commit to temawi/grpc-java that referenced this pull request Oct 13, 2021
The test driver install script is read directly from the core repo master branch and the copy in the Java repo is deleted.
temawi added a commit to temawi/grpc-java that referenced this pull request Oct 13, 2021
The test driver install script is read directly from the core repo master branch and the copy in the Java repo is deleted.
temawi added a commit to temawi/grpc-java that referenced this pull request Oct 13, 2021
The test driver install script is read directly from the core repo master branch and the copy in the Java repo is deleted.
temawi added a commit to temawi/grpc-java that referenced this pull request Oct 13, 2021
The test driver install script is read directly from the core repo master branch and the copy in the Java repo is deleted.
temawi added a commit to temawi/grpc-java that referenced this pull request Oct 13, 2021
The test driver install script is read directly from the core repo master branch and the copy in the Java repo is deleted.
temawi added a commit that referenced this pull request Oct 13, 2021
The test driver install script is read directly from the core repo master branch and the copy in the Java repo is deleted.
temawi added a commit that referenced this pull request Oct 13, 2021
The test driver install script is read directly from the core repo master branch and the copy in the Java repo is deleted.
temawi added a commit that referenced this pull request Oct 14, 2021
The test driver install script is read directly from the core repo master branch and the copy in the Java repo is deleted.
temawi added a commit that referenced this pull request Oct 14, 2021
The test driver install script is read directly from the core repo master branch and the copy in the Java repo is deleted.
temawi added a commit that referenced this pull request Oct 14, 2021
The test driver install script is read directly from the core repo master branch and the copy in the Java repo is deleted.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants