Skip to content

Add testing_version flag#8534

Merged
ejona86 merged 1 commit intogrpc:masterfrom
lidizheng:skip-master
Sep 27, 2021
Merged

Add testing_version flag#8534
ejona86 merged 1 commit intogrpc:masterfrom
lidizheng:skip-master

Conversation

@lidizheng
Copy link
Copy Markdown
Contributor

@lidizheng lidizheng marked this pull request as ready for review September 17, 2021 20:03
@lidizheng
Copy link
Copy Markdown
Contributor Author

Bump the PR.

Comment thread buildscripts/kokoro/xds_url_map.sh Outdated
@ejona86
Copy link
Copy Markdown
Member

ejona86 commented Sep 22, 2021

I'm not sure how to merge this, since it is a "backport" (but not a backport, more of just a copy), but now it is different than the original. I didn't realize that when I made my comment.

@lidizheng
Copy link
Copy Markdown
Contributor Author

lidizheng commented Sep 27, 2021

This is my bad. I was using the same ad-hoc script to generate commit and PR. This flag is used to allow test cases to skip for unsupported client/server. Today, Java supports all test cases. This PR is a preventive work for future gap, or deprecation.

@ejona86 PTALAAA.

@ejona86 ejona86 merged commit 0287d83 into grpc:master Sep 27, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants