Allow custom element resize handler#3142
Conversation
|
I have no idea why it shows so many changes in types.ts |
src/dd-resizable-handle.ts
Outdated
| : this.host.querySelector(this.option.element) | ||
| } else { | ||
| this.el = document.createElement('div'); | ||
| this.el.classList.add('ui-resizable-handle'); |
There was a problem hiding this comment.
you probably should always do this. also if querySelector() fails, you still want to create our own div flow
looks like line ending formatting change (ignore white space shows just the few lines you added). I used to be on windows and likely the difference (I assume you're on mac ? ) |
Yes, yeah my VS Code and git is configured to Force LF endings. I can change that later |
adumesny
left a comment
There was a problem hiding this comment.
thanks for the feature. I will tweak it further...
Description
This changes searches for a resize handler inside the widget host and uses it instead of creating one. I have tested that in our app and it works perfectly (currently patched our version).
I can extend the readme if you point me out where to add that.
Tests fail with this, which I think is an issue with how you setup the repo:
Checklist
yarn test)closes: #3104