Skip to content

allow retrieval of failed job counter #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gresrun merged 1 commit into from
Dec 30, 2021
Merged

allow retrieval of failed job counter #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/main/java/net/greghaines/jesque/meta/dao/FailureDAO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,15 @@
public interface FailureDAO {

/**
* @return total number of failures
* @return total number of jobs that failed
*/
long getCount();

/**
* @return number of jobs in the fail queue
*/
long getFailQueueJobCount();

/**
* @param offset offset into the failures
* @param count number of failures to return
Expand Down
18 changes: 18 additions & 0 deletions src/main/java/net/greghaines/jesque/meta/dao/impl/FailureDAORedisImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import static net.greghaines.jesque.utils.ResqueConstants.FAILED;
import static net.greghaines.jesque.utils.ResqueConstants.QUEUE;
import static net.greghaines.jesque.utils.ResqueConstants.QUEUES;
import static net.greghaines.jesque.utils.ResqueConstants.STAT;

import java.io.IOException;
import java.util.ArrayList;
Expand Down Expand Up @@ -67,6 +68,23 @@ public FailureDAORedisImpl(final Config config, final Pool<Jedis> jedisPool) {
*/
@Override
public long getCount() {
return PoolUtils.doWorkInPoolNicely(this.jedisPool, new PoolWork<Jedis, Long>() {
/**
* {@inheritDoc}
*/
@Override
public Long doWork(final Jedis jedis) throws Exception {
final String failedStr = jedis.get(key(STAT, FAILED));
return (failedStr == null) ? 0L : Long.parseLong(failedStr);
}
});
}

/**
* {@inheritDoc}
*/
@Override
public long getFailQueueJobCount() {
return PoolUtils.doWorkInPoolNicely(this.jedisPool, new PoolWork<Jedis, Long>() {
/**
* {@inheritDoc}
Expand Down
22 changes: 18 additions & 4 deletions src/test/java/net/greghaines/jesque/meta/dao/impl/TestFailureDAORedisImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import static net.greghaines.jesque.utils.ResqueConstants.COLON;
import static net.greghaines.jesque.utils.ResqueConstants.FAILED;
import static net.greghaines.jesque.utils.ResqueConstants.QUEUES;
import static net.greghaines.jesque.utils.ResqueConstants.STAT;

import java.io.IOException;
import java.util.ArrayList;
Expand Down Expand Up @@ -35,6 +36,7 @@
public class TestFailureDAORedisImpl {

private static final String FAILED_KEY = DEFAULT_NAMESPACE + COLON + FAILED;
private static final String FAILED_STAT_KEY = DEFAULT_NAMESPACE + COLON + STAT + COLON + FAILED;
private static final String QUEUES_KEY = DEFAULT_NAMESPACE + COLON + QUEUES;

private Mockery mockCtx;
Expand Down Expand Up @@ -71,16 +73,28 @@ public void testConstructor_NullPool() {

@Test
public void testGetCount() {
final long failCount = 12;
final String failCount = "12";
this.mockCtx.checking(new Expectations(){{
oneOf(pool).getResource(); will(returnValue(jedis));
oneOf(jedis).llen(FAILED_KEY); will(returnValue(failCount));
oneOf(jedis).get(FAILED_STAT_KEY); will(returnValue(failCount));
oneOf(jedis).close();
}});
final long count = this.failureDAO.getCount();
Assert.assertEquals(failCount, count);
Assert.assertEquals(Long.parseLong(failCount), count);
}


@Test
public void testGetFailQueueJobCount() {
final long failQueueJobCount = 12;
this.mockCtx.checking(new Expectations(){{
oneOf(pool).getResource(); will(returnValue(jedis));
oneOf(jedis).llen(FAILED_KEY); will(returnValue(failQueueJobCount));
oneOf(jedis).close();
}});
final long count = this.failureDAO.getFailQueueJobCount();
Assert.assertEquals(failQueueJobCount, count);
}

@Test
public void testClear() {
this.mockCtx.checking(new Expectations(){{
Expand Down