Reload redis scripts on reconnect#143
Merged
gresrun merged 3 commits intoJul 11, 2018
Merged
Conversation
ofirnk
reviewed
Jun 22, 2018
ofirnk
left a comment
ofirnk
left a comment
Contributor
There was a problem hiding this comment.
Simple and to the point 🎉
| try { | ||
| loadRedisScripts(); | ||
| } catch (IOException e) { | ||
| LOG.error("Failed to load redis scripts", e); |
Contributor
There was a problem hiding this comment.
Maybe Failed to reload Lua scripts after reconnect
ofirnk
approved these changes
Jun 22, 2018
ofirnk
left a comment
ofirnk
left a comment
Contributor
There was a problem hiding this comment.
maybe write few words whether and how this was tested?
Anyway, It lgtm 👍
Contributor
Author
|
To test this, I basically initialized and started a Without this fix, EDIT: tested with redis docker v3.2.12 |
Contributor
|
Cool, sounds good 👏 |
argvk
approved these changes
Jun 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #100