properly handle delayed queues when using RESET_TO_HIGHEST_PRIORITY s…#133
Merged
Merged
Conversation
ofirnk
approved these changes
Jan 2, 2018
ofirnk
left a comment
ofirnk
left a comment
Contributor
There was a problem hiding this comment.
Other than small question, LGTM 👍
|
|
||
| if queueType == 'zset' then | ||
| local firstMsg = redis.call('ZRANGE', queueName, '0', '0') | ||
| local firstMsg = redis.call('ZRANGEBYSCORE', queueName, '-inf', now, 'WITHSCORES', 'LIMIT', '0', '1') |
Contributor
There was a problem hiding this comment.
Maybe I forgot already, but why WITHSCORES is needed here?
Contributor
Author
There was a problem hiding this comment.
that's not needed indeed, nice catch
i also removed it from the jesque_pop lua script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…trategy
fixes #126