Skip to content

add nextQueueStrategy feature to WorkerPoolImpl#132

Merged
gresrun merged 1 commit into
gresrun:masterfrom
uberall:WorkerPoolImpl-nextQueueStrategy
Dec 30, 2017
Merged

add nextQueueStrategy feature to WorkerPoolImpl#132
gresrun merged 1 commit into
gresrun:masterfrom
uberall:WorkerPoolImpl-nextQueueStrategy

Conversation

@bp-FLN

@bp-FLN bp-FLN commented Dec 27, 2017

Copy link
Copy Markdown
Contributor

The nextQueueStrategy feature was added in #107, but only for WorkerImpl.
This patch adds the feature also to the WorkerPoolImpl.

@bp-FLN

bp-FLN commented Dec 27, 2017

Copy link
Copy Markdown
Contributor Author

What about having some common base class for the WorkerImpl and WorkerPoolImpl? Like AbstractWorker or smth similar.
Would save us quite some duplicated code. What do you think @gresrun?

@gresrun

gresrun commented Dec 30, 2017

Copy link
Copy Markdown
Owner

Florian, I agree, the two should share a common base class. Should have done that work when I first created WorkerPoolImpl but I guess I got lazy!

@gresrun
gresrun merged commit 51760f4 into gresrun:master Dec 30, 2017
@bp-FLN
bp-FLN deleted the WorkerPoolImpl-nextQueueStrategy branch December 31, 2017 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants