feat: add backend CRUD for providers, assets, and transactions#1
Open
grazo99 wants to merge 8 commits into
Open
feat: add backend CRUD for providers, assets, and transactions#1grazo99 wants to merge 8 commits into
grazo99 wants to merge 8 commits into
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use @IsDateString() for date field, @ispositive() for quantity/price - Validate providerId exists in create() and update() - Validate assetId exists in update() - Add @isnotempty() on optional providerId to reject empty strings - Add @unique constraint on Asset.ticker with 409 conflict handling - Add 6 new unit tests covering all validation cases (23 total) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spec:
docs/specs/001-create-transaction/spec.md25 tests passing (17 unit + 8 e2e)
Test plan
cd apps/api && pnpm jest --verbose— 17 unit tests passcd apps/api && pnpm jest --config test/jest-e2e.json --verbose— 8 e2e tests pass🤖 Generated with Claude Code