polish(ast): prefer undefined over empty arrays by yaacovCR · Pull Request #4206 · graphql/graphql-js

yaacovCR · 2024-09-27T08:10:59Z

Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers.

This closes #2203 as our tests now cover the undefined case by default whenever there is an empty array.

netlify · 2024-09-27T08:11:17Z

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name	Link
🔨 Latest commit	`125c2b7`
🔍 Latest deploy log	https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/670cf48b36880d0008726e05
😎 Deploy Preview	https://deploy-preview-4206--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-09-27T08:11:31Z

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

@github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
@github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

yaacovCR · 2024-09-28T21:09:16Z

Well, it works!

It would seem that it's more accurate to use undefined when an optionalMany(...) is skipped entirely and an empty array when it is found, but has an empty list. So, it would seem that this PR is technically more correct.

Peeking around at https://astexplorer.net/ it seems that TS parser has some empty arrays, some undefined, while for Babel I didn't on a very cursory look see any undefined.

But still not 100% sure this is too compelling, with the status quo being somewhat compelling! Comments welcome!

yaacovCR · 2024-10-14T08:54:01Z

Merging this PR allows us to close #2203, improving robustness of our test coverage. Presumably our downstream users were also affected by #2203 and had to account for manually created AST nodes, so they should be robust to this change, but I upgraded it to a breaking change anyway just to call it out.

JoviDeCroock · 2024-10-14T09:06:26Z

Probably needs a rebase

extracted from #4206

…phql#4236) extracted from graphql#4206

see: graphql#2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes graphql#2203 as our tests now cover the undefined case by default whenever there is an empty array.

…phql#4236) extracted from graphql#4206

see: graphql#2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes graphql#2203 as our tests now cover the undefined case by default whenever there is an empty array.

…phql#4236) extracted from graphql#4206

see: graphql#2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes graphql#2203 as our tests now cover the undefined case by default whenever there is an empty array.

…phql#4236) extracted from graphql#4206

see: graphql#2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes graphql#2203 as our tests now cover the undefined case by default whenever there is an empty array.

…phql#4236) extracted from graphql#4206

see: graphql#2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes graphql#2203 as our tests now cover the undefined case by default whenever there is an empty array.

…phql#4236) extracted from graphql#4206

see: graphql#2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes graphql#2203 as our tests now cover the undefined case by default whenever there is an empty array.

extracted from #4206

see: #2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes #2203 as our tests now cover the undefined case by default whenever there is an empty array.

extracted from #4206

see: #2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes #2203 as our tests now cover the undefined case by default whenever there is an empty array.

…phql#4236) extracted from graphql#4206

see: graphql#2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes graphql#2203 as our tests now cover the undefined case by default whenever there is an empty array.

extracted from #4206

see: #2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes #2203 as our tests now cover the undefined case by default whenever there is an empty array.

extracted from #4206

see: #2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes #2203 as our tests now cover the undefined case by default whenever there is an empty array.

extracted from #4206

see: #2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes #2203 as our tests now cover the undefined case by default whenever there is an empty array.

extracted from #4206

see: #2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes #2203 as our tests now cover the undefined case by default whenever there is an empty array.

extracted from #4206

see: #2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes #2203 as our tests now cover the undefined case by default whenever there is an empty array.

extracted from #4206

see: #2405 (comment) Manually created ASTs always allowed undefined in place of empty arrays; this change simply updates the parser to more closely follow the manual approach. This is therefore not technically a breaking change, but considering that there may be tools not aware of this, we have labelled it a BREAKING_CHANGE to highlight it for consumers. This closes #2203 as our tests now cover the undefined case by default whenever there is an empty array.

yaacovCR requested a review from a team as a code owner September 27, 2024 08:10

yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Sep 27, 2024

yaacovCR mentioned this pull request Sep 27, 2024

Make variableDefinitions not nullable #2405

Closed

yaacovCR marked this pull request as draft September 27, 2024 08:49

yaacovCR closed this Sep 27, 2024

yaacovCR reopened this Sep 28, 2024

yaacovCR force-pushed the suggestion-from-alternative branch 2 times, most recently from 60e7d7f to aee3bb9 Compare September 28, 2024 21:04

yaacovCR marked this pull request as ready for review September 28, 2024 21:09

yaacovCR marked this pull request as draft October 1, 2024 10:31

Thompson1985 approved these changes Oct 6, 2024

View reviewed changes

yaacovCR added PR: breaking change 💥 implementation requires increase of "major" version number and removed PR: polish 💅 PR doesn't change public API or any observed behaviour labels Oct 14, 2024

yaacovCR requested a review from JoviDeCroock October 14, 2024 08:51

yaacovCR marked this pull request as ready for review October 14, 2024 08:52

JoviDeCroock approved these changes Oct 14, 2024

View reviewed changes

yaacovCR force-pushed the suggestion-from-alternative branch from f5bf1bb to 9e6f027 Compare October 14, 2024 09:29

yaacovCR mentioned this pull request Oct 14, 2024

fix(replaceVariables): handle missing individual variable source #4236

Merged

yaacovCR added a commit that referenced this pull request Oct 14, 2024

fix(replaceVariables): handle missing individual variable source (#4236)

cdd293d

extracted from #4206

yaacovCR added 2 commits October 14, 2024 13:29

prefer undefined over empty arrays

513edb4

use the change in this PR to close 2203

125c2b7

yaacovCR force-pushed the suggestion-from-alternative branch from bdde1db to 125c2b7 Compare October 14, 2024 10:38

yaacovCR requested a review from JoviDeCroock October 14, 2024 10:39

JoviDeCroock approved these changes Oct 14, 2024

View reviewed changes

yaacovCR merged commit bb8e574 into graphql:main Oct 14, 2024

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025

fix(replaceVariables): handle missing individual variable source (gra…

8d63ed1

…phql#4236) extracted from graphql#4206

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 16, 2025

fix(replaceVariables): handle missing individual variable source (gra…

2e6ba08

…phql#4236) extracted from graphql#4206

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025

fix(replaceVariables): handle missing individual variable source (gra…

1b0f5e3

…phql#4236) extracted from graphql#4206

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 17, 2025

fix(replaceVariables): handle missing individual variable source (gra…

99eda79

…phql#4236) extracted from graphql#4206

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 19, 2025

fix(replaceVariables): handle missing individual variable source (gra…

2c56d00

…phql#4236) extracted from graphql#4206

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Dec 22, 2025

fix(replaceVariables): handle missing individual variable source (gra…

5a31790

…phql#4236) extracted from graphql#4206

yaacovCR added a commit that referenced this pull request Dec 22, 2025

fix(replaceVariables): handle missing individual variable source (#4236)

d4d2527

extracted from #4206

yaacovCR added a commit that referenced this pull request Dec 22, 2025

fix(replaceVariables): handle missing individual variable source (#4236)

df6be60

extracted from #4206

yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Jan 27, 2026

fix(replaceVariables): handle missing individual variable source (gra…

dd20f75

…phql#4236) extracted from graphql#4206

yaacovCR added a commit that referenced this pull request Feb 22, 2026

fix(replaceVariables): handle missing individual variable source (#4236)

d610b6c

extracted from #4206

yaacovCR added a commit that referenced this pull request Feb 23, 2026

fix(replaceVariables): handle missing individual variable source (#4236)

237e954

extracted from #4206

yaacovCR added a commit that referenced this pull request Feb 24, 2026

fix(replaceVariables): handle missing individual variable source (#4236)

32575fe

extracted from #4206

yaacovCR added a commit that referenced this pull request Feb 24, 2026

fix(replaceVariables): handle missing individual variable source (#4236)

33091f7

extracted from #4206

yaacovCR added a commit that referenced this pull request Feb 24, 2026

fix(replaceVariables): handle missing individual variable source (#4236)

538e1f8

extracted from #4206

yaacovCR added a commit that referenced this pull request Feb 24, 2026

fix(replaceVariables): handle missing individual variable source (#4236)

362e4b3

extracted from #4206

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

polish(ast): prefer undefined over empty arrays#4206

polish(ast): prefer undefined over empty arrays#4206
yaacovCR merged 2 commits into
graphql:mainfrom
yaacovCR:suggestion-from-alternative

yaacovCR commented Sep 27, 2024 •

edited

Loading

Uh oh!

netlify Bot commented Sep 27, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 27, 2024

Uh oh!

yaacovCR commented Sep 28, 2024

Uh oh!

yaacovCR commented Oct 14, 2024

Uh oh!

JoviDeCroock commented Oct 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

yaacovCR commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Uh oh!

github-actions Bot commented Sep 27, 2024

Uh oh!

yaacovCR commented Sep 28, 2024

Uh oh!

yaacovCR commented Oct 14, 2024

Uh oh!

JoviDeCroock commented Oct 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yaacovCR commented Sep 27, 2024 •

edited

Loading

netlify Bot commented Sep 27, 2024 •

edited

Loading