Pass full tpar list to draw_facet_window#481
Merged
grantmcdermott merged 3 commits intomainfrom Sep 17, 2025
Merged
Conversation
- tweak get_tpar() while we're at it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #475
Upon further investigation, I realised that several other graphical parameters (not just
dynmar) weren't being realised correctly during non-interactive calls.For example, the grid lines in this example on the website are not showing up correctly, while the axes themselves are slightly too thick (and thus visible in comparison to the plot box):
This PR effectively sidesteps the problem by passing the entire
tpar()list as part of therecordGraphics(draw_facet_window, list(..., tpars = tpar())call. I also adjusted some ancillary function to make them compatible with this change.