Skip to content

ridge palette#415

Merged
grantmcdermott merged 3 commits intomainfrom
ridge_pal
Jun 1, 2025
Merged

ridge palette#415
grantmcdermott merged 3 commits intomainfrom
ridge_pal

Conversation

@grantmcdermott
Copy link
Copy Markdown
Owner

Fixes #414

Also update some test snapshots while we're at it, so that they use/test against the default ridge theme palette. (The old tests passed a bespoke palette and that's why we missed this regression during the previous release.)

@grantmcdermott grantmcdermott merged commit 42dede7 into main Jun 1, 2025
3 checks passed
@grantmcdermott grantmcdermott deleted the ridge_pal branch June 1, 2025 20:43
@zeileis
Copy link
Copy Markdown
Collaborator

zeileis commented Jun 1, 2025

Great, thanks for the quick fix!

@grantmcdermott
Copy link
Copy Markdown
Owner Author

Nps!

RE: our discussion whether to submit a hot(ish) fix to CRAN. One extra thing I might do is tweak the final type_function() example to use function(x) instead of \(x) so that we can re-pin R4.0.0 as our minimum version. I doubt it will make much difference in practice, but seems a small burden to gain some extra backwards compatibility.

@zeileis
Copy link
Copy Markdown
Collaborator

zeileis commented Jun 1, 2025

Good idea. I regularly have students who have trouble using recent versions of R because they are not able to upgrade their macOS system and are stuck with something like Catalina. So I guess that there is a market for 4.0.0-compatible packages 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong color legend in ridge theme/plot

2 participants