Skip to content

rename test files with type prefix#309

Merged
grantmcdermott merged 2 commits intograntmcdermott:mainfrom
vincentarelbundock:reorg_test_files
Feb 7, 2025
Merged

rename test files with type prefix#309
grantmcdermott merged 2 commits intograntmcdermott:mainfrom
vincentarelbundock:reorg_test_files

Conversation

@vincentarelbundock
Copy link
Copy Markdown
Collaborator

We are starting to have a lot of test files. I think it's useful to add a type prefix to the type-specific tests. Just helps us navigate and organize the tests better.

@grantmcdermott
Copy link
Copy Markdown
Owner

Hmmm, looks like an error with one of the tinyplot_add tests. Is your fork up to date with main?

(On that note, I've been meaning to say that you should feel free to branch directly off of the main repo for your PRs. Makes it easier for me to test and contribute patches locally. No biggie, though.)

@vincentarelbundock
Copy link
Copy Markdown
Collaborator Author

(On that note, I've been meaning to say that you should feel free to branch directly off of the main repo for your PRs. Makes it easier for me to test and contribute patches locally. No biggie, though.)

will try to think about it

Hmmm, looks like an error with one of the tinyplot_add tests. Is your fork up to date with main?

There was no see for a jitter snapshot, so I think we were relying on the order of operations and an earlier set seed. So this was a side effects issue.

I set a seed and created a new snapshot. Should be unobjectionable, I think.

@grantmcdermott
Copy link
Copy Markdown
Owner

There was no see for a jitter snapshot, so I think we were relying on the order of operations and an earlier set seed. So this was a side effects issue.

Good catch!

@grantmcdermott grantmcdermott merged commit 4d06eab into grantmcdermott:main Feb 7, 2025
@vincentarelbundock vincentarelbundock deleted the reorg_test_files branch September 9, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants