Issue #307 cex should be respected with type="b"#308
Merged
vincentarelbundock merged 4 commits intograntmcdermott:mainfrom Feb 7, 2025
Merged
Issue #307 cex should be respected with type="b"#308vincentarelbundock merged 4 commits intograntmcdermott:mainfrom
cex should be respected with type="b"#308vincentarelbundock merged 4 commits intograntmcdermott:mainfrom
Conversation
| Type: Package | ||
| Title: Lightweight Extension of the Base R Graphics System | ||
| Version: 0.3.0 | ||
| Version: 0.3.0.1 |
Owner
There was a problem hiding this comment.
Nit: can we stick with the '.99' suffix convention for dev versions? Much as I'd like to increment with each PR, I don't think we'll be disciplined to stick to it and this approach avoids that kind of ambiguity at least. (Following data.table's lead here...)
Collaborator
Author
There was a problem hiding this comment.
do we need the date in DESCRIPTION? I don't think I include it in any of my packages. And that seems like an incrementation annoyance as well.
grantmcdermott
requested changes
Feb 7, 2025
Owner
grantmcdermott
left a comment
grantmcdermott
left a comment
There was a problem hiding this comment.
LGTM. One minor nit but then feel free to merge.
Thanks for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.