type_function#250
Merged
vincentarelbundock merged 2 commits intoNov 13, 2024
Merged
Conversation
Collaborator
vincentarelbundock
commented
Nov 12, 2024
Closed
grantmcdermott
previously requested changes
Nov 13, 2024
Owner
grantmcdermott
left a comment
There was a problem hiding this comment.
Loving the Vincent productivity shock ;-)
This looks excellent. Do you mind adding a test and then I'm happy to merge. (Or feel free to do so yourself if all checks are passing.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
